Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

convert empty string to empty collection or array #54

Merged
merged 4 commits into from
May 14, 2021
Merged

convert empty string to empty collection or array #54

merged 4 commits into from
May 14, 2021

Conversation

Mkabaka
Copy link
Member

@Mkabaka Mkabaka commented May 11, 2021

No description provided.

@Mkabaka Mkabaka requested a review from alalag1 May 11, 2021 12:45
alalag1
alalag1 requested changes May 12, 2021
View reviewed changes
Copy link
Member

@alalag1 alalag1 left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Make ConverterUtils provide a converter with explicit rules

  • convert null to null
  • convert empty string type by type
    • throw an exception if the target type is a primitive type
    • convert to empty Collection or Array

plz do not change the imports with '*'

@alalag1 alalag1 linked an issue May 12, 2021 that may be closed by this pull request
Binding array or list parameters by @RequestParam #16
Closed
@alalag1 alalag1 removed a link to an issue May 12, 2021
Binding array or list parameters by @RequestParam #16
Closed
@alalag1 alalag1 linked an issue May 12, 2021 that may be closed by this pull request
Got 400 error when annotating argument with @RequestParam(default value = "") #43
Closed
@alalag1 alalag1 self-requested a review May 14, 2021 02:00
alalag1
alalag1 requested changes May 14, 2021
View reviewed changes
restlight-common/src/main/java/esa/restlight/core/util/ConverterUtils.java Outdated Show resolved Hide resolved
restlight-common/src/main/java/esa/restlight/core/util/ConverterUtils.java Outdated Show resolved Hide resolved
...core/src/main/java/esa/restlight/core/resolver/arg/AbstractNameAndValueArgumentResolver.java Outdated Show resolved Hide resolved
...core/src/main/java/esa/restlight/core/resolver/arg/AbstractNameAndValueArgumentResolver.java Outdated Show resolved Hide resolved
...core/src/main/java/esa/restlight/core/resolver/arg/AbstractNameAndValueArgumentResolver.java Outdated Show resolved Hide resolved
...-core/src/main/java/esa/restlight/core/resolver/arg/AbstractRequestBodyArgumentResolver.java Show resolved Hide resolved
restlight-core/src/main/java/esa/restlight/core/resolver/arg/NameAndValue.java Outdated Show resolved Hide resolved
restlight-jaxrs-provider/src/main/java/esa/restlight/jaxrs/util/JaxrsMappingUtils.java Outdated Show resolved Hide resolved
@Mkabaka Mkabaka requested a review from alalag1 May 14, 2021 06:24
@alalag1 alalag1 merged commit a5920d0 into esastack:main May 14, 2021
@Mkabaka Mkabaka deleted the convert_empty_string_to_empty_collection branch May 14, 2021 07:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@alalag1 alalag1 alalag1 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Got 400 error when annotating argument with @RequestParam(default value = "")
2 participants
@Mkabaka @alalag1