Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Import Souncloud tracks uploaded date and tags #84

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

Simounet
Copy link
Contributor

  • Handle created_at field from Soundcloud's tracks import so they can be
    at the right position in the timeline
  • Function to parse the tag_list field from the Soundcloud API
  • Add a created_at field to the soundcloud_data table
  • Var DATABASE_VERSION from index.php updated

- Handle created_at field from Soundcloud's tracks import so they can be
  at the right position in the timeline
- Function to parse the tag_list field from the Soundcloud API
- Add a created_at field to the soundcloud_data table
- Var DATABASE_VERSION from index.php updated
@eschnou
Copy link
Owner

eschnou commented Jan 29, 2014

Thanks for your continued contributions :-)

I have an issue with this one: the soundcloud plugin currently only imports the user favorites (this can probably be easily extended to uploaded tracks as well). For favorites, I want the entry to be in my stream at the date/time when I favorited it, not when the track got uploaded (could have been years ago).

So, your fix would be the correct behavior for user uploaded tracks, but I don't like this behavior for favorites. What do you think? What use case did you have in mind?

@Simounet
Copy link
Contributor Author

I agree. My next move will be to import our own tracks but I'll try to get the fav' date for favs before.

@Simounet
Copy link
Contributor Author

Hewww, it doesn't seem to be possible atm: http://stackoverflow.com/a/20856588/2550448 . I've send a mail to the Soundcloud's API guys. I'll see if I can get a reply about this feature.
In the mean time, can I split this PR with the tags feature, if it looks ok for you?

@eschnou
Copy link
Owner

eschnou commented Jan 29, 2014

Sure!

Aboute the date, I don't think it is too much an issue. My update cron job runs every five minutes. So, worst case is I'm off 5 minutes :-) The issue is when importing the feed the first time. So, one solution would be:

  • use the created timestamp on import (as long as we don't have anything better)
  • use the current timestamp when updating

This reverts commit 921a5f9.
Revert created_at date handling for SoundClound favorites imported
tracks because SoundCloud API doesn't provide the date for favorite
action at the moment.
Tracks were imported with it creation date on SoundCloud and not with the
user favorite action date.
@Simounet
Copy link
Contributor Author

Simounet commented Nov 5, 2014

Hi Laurent,
Time is passing by too fast... I made a patch and removed the created_at date handling. It's just for the tags' impot now.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants