Skip to content

Commit

Permalink
Adding GoLang Linter
Browse files Browse the repository at this point in the history
  • Loading branch information
safaci2000 committed Sep 28, 2023
1 parent ac5f68b commit 8421dfa
Show file tree
Hide file tree
Showing 3 changed files with 32 additions and 37 deletions.
37 changes: 0 additions & 37 deletions .github/workflows/go.yml
Original file line number Diff line number Diff line change
Expand Up @@ -7,42 +7,11 @@ on:
pull_request:

jobs:
# lint:
# strategy:
# matrix:
# go: [ 1.20.2 ]
#
# runs-on: ubuntu-latest
# steps:
# - uses: actions/checkout@v3
#
# - name: Set up Go
# uses: actions/setup-go@v4
# with:
# go-version: ${{ matrix.go }}
#
# - uses: actions/cache@v2
# with:
# path: |
# ~/go/pkg/mod
# key: ${{ runner.os }}-go-${{ hashFiles('**/go.sum') }}
# restore-keys: |
# ${{ runner.os }}-go-
#
# - name: Verify go version
# run: go version
#
# - name: Run linters
# uses: golangci/[email protected]
# with:
# version: v1.52.1

test:
strategy:
matrix:
go: [ 1.21.0]
grafana: [ 9.4.3, 10.0.0 ]
chromedp: [ 112.0.5615.39 ]

env:
GRAFANA_INTEGRATION: 1
Expand All @@ -62,12 +31,6 @@ jobs:
- 3000:3000
options: >-
-e GF_AUTH_ANONYMOUS_ENABLED=true
chromedp:
image: "chromedp/headless-shell:${{ matrix.chromedp }}"
ports:
- 9222:9222
options: >-
--shm-size 2G
runs-on: ubuntu-latest
steps:
Expand Down
31 changes: 31 additions & 0 deletions .github/workflows/golangci-lint.yml
Original file line number Diff line number Diff line change
@@ -0,0 +1,31 @@
name: golangci-lint
on:
push:
branches:
- master
pull_request:


permissions:
contents: read
# Optional: allow read access to pull request. Use with `only-new-issues` option.
# pull-requests: read

jobs:
golangci:
name: lint
runs-on: ubuntu-latest
steps:
- uses: actions/checkout@v3
- uses: actions/setup-go@v4
with:
go-version: '1.21'
cache: false
- name: golangci-lint
uses: golangci/golangci-lint-action@v3
with:
# Require: The version of golangci-lint to use.
# When `install-mode` is `binary` (default) the value can be v1.2 or v1.2.3 or `latest` to use the latest version.
# When `install-mode` is `goinstall` the value can be v1.2.3, `latest`, or the hash of a commit.
version: v1.54
args: --timeout=30m
1 change: 1 addition & 0 deletions test/connections_integration_test.go
Original file line number Diff line number Diff line change
Expand Up @@ -62,6 +62,7 @@ func TestDataSourceFilter(t *testing.T) {
},
}
testingContext = config.Config().GetAppConfig().GetContexts()["testing"]
_ = testingContext

apiClient := service.NewApiService("dummy")

Expand Down

0 comments on commit 8421dfa

Please sign in to comment.