Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Switching to official grafana OpenAPI #208

Merged
merged 2 commits into from
Nov 22, 2023
Merged

Switching to official grafana OpenAPI #208

merged 2 commits into from
Nov 22, 2023

Conversation

safaci2000
Copy link
Contributor

No description provided.

@safaci2000 safaci2000 marked this pull request as draft October 25, 2023 20:49
@safaci2000 safaci2000 force-pushed the feature/switchAPI branch 3 times, most recently from 6acda4f to fffbb1a Compare November 4, 2023 02:59
@safaci2000 safaci2000 added this to the 0.5.2 milestone Nov 6, 2023
@safaci2000 safaci2000 force-pushed the feature/switchAPI branch 3 times, most recently from d145b2e to 144e440 Compare November 13, 2023 16:09
@safaci2000 safaci2000 force-pushed the feature/switchAPI branch 2 times, most recently from 652d1d3 to 41cb159 Compare November 21, 2023 13:26
@safaci2000 safaci2000 marked this pull request as ready for review November 21, 2023 13:26
Copy link
Contributor

@daldoyle daldoyle left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Overall looks good, a few cleanup items mentioned in here.

internal/config/config_test.go Outdated Show resolved Hide resolved
internal/service/folders.go Outdated Show resolved Hide resolved
internal/service/folders.go Show resolved Hide resolved
@safaci2000 safaci2000 merged commit 560d874 into master Nov 22, 2023
5 checks passed
@safaci2000 safaci2000 deleted the feature/switchAPI branch November 22, 2023 15:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

2 participants