test: [TERR-53] Code Coverage for Grafana Network Map Panel Plugin Component Testing #45
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…hub.com:esnet/grafana-esnet-networkmap-panel into feat/TERR-53-code-coverage
- added reporters to karma config - refactored santize functions into utils module - narrowed scope of coverage testing to non-d3, non-leaflet, non-pubsub code - corrected imports of santize functions - refactored render function to use resolvePath - removed resolveObjPath fn from templates module - removed topologyTools module - added some jsdoc inlinedocs for utils module - refactored util fn name from getUrlSearchParams to getUrlQueryParams
|
Closed due to changes improved upon and merged via PR-49: test: React Component Code Coverage and Error Validation |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds code coverage reporting (through Istanbul) to component testing in the Network Map Grafana Plugin. It is limited to testing non-React components and is seperate from E2E testing.
Checklist
type: [TERR-XXX] Short descriptiontypeis one of: 'build', 'ci', 'chore', 'docs', 'feat', 'fix', 'perf', 'refactor', 'revert', 'style', 'test'TERR-XXXrefers to a Jira issue.