Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add MPTCP support with the --multipath flag #1615

Closed
wants to merge 1 commit into from

Conversation

marcosfsch
Copy link
Contributor

  • Version of iperf3 (or development branch, such as master or
    3.1-STABLE) to which this pull request applies:
    master

  • Issues fixed (if any):
    Rebase of PR #1166, including testing for MPTCP support.

  • Brief description of code changes (suitable for use as a commit message):
    Recent version of the Linux kernel (5.9) gained MPTCP support, this change
    allows easy testing such protocol.
    MPTCP is strongly tied to TCP, and the kernel APIs are almost the same,
    so this change does not implement a new 'struct protocol'. Instead it just
    extend the TCP support to optionally enable multipath via the --multipath or
    -m switch.

The only required dependency is the 'IPPROTO_MPTCP' protocol number
definition, which should be provided by the netinet/in.h header.
To keep things simple, just conditionally provide the required
protocol, if the system header does not have it yet.

@matttbe
Copy link

matttbe commented Jun 19, 2024

@marcosfsch thank you for this rebase. @geliangtang did another one in #1661 with some small modifications discussed with the MPTCP devs:

  • no build check: better to check at run-time, the kernel could be different
  • --mptcp (shorter) instead of --multipath (too vague, could be multipath QUIC, etc.)
  • place the new proto arg after type in the modified function signatures.

Are the modifications OK for you? Would it be OK to close this PR?
Hopefully IPerf3 devs will be able to review #1661 soon :)

@marcosfsch
Copy link
Contributor Author

marcosfsch commented Jun 19, 2024 via email

@marcosfsch marcosfsch closed this Jun 19, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants