Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

No limit to omit time period #1774

Merged
merged 2 commits into from
Nov 22, 2024

Conversation

davidBar-On
Copy link
Contributor

  • Version of iperf3 (or development branch, such as master or
    3.1-STABLE) to which this pull request applies:
    master

  • Issues fixed (if any): iperf3 -O (--omit) to get more than 60 seconds omit time #1770

  • Brief description of code changes (suitable for use as a commit message):
    Change the --omit time period limit from 60 to the same limit as --time (86,400 seconds = one day).
    My assumption is that the 60 seconds was just to be more user friendly, assuming that the omit period is only to omit possible performance fluctuations at the first few seconds of the tests. Per iperf3 -O (--omit) to get more than 60 seconds omit time #1770 there are other use cases that requires larger omit time period.

@bmah888
Copy link
Contributor

bmah888 commented Sep 24, 2024

Thanks for the PR! Some of these hard limits exist to put sane boundaries on some of the test parameters, the idea being that if a user really needed to do say very long tests they should be at least knowlegable enough to modify the code and recompile it.

In this case, there (probably?) isn't any particular resource constraint caused by having longer --omit times, so it probably makes sense to change the bound as in this PR.

Copy link
Contributor

@bmah888 bmah888 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks again for the PR! I sorta changed my mind about how I feel about this, I'd like to do this in a slightly different way.

src/iperf_api.c Outdated Show resolved Hide resolved
@bmah888 bmah888 linked an issue Nov 22, 2024 that may be closed by this pull request
Copy link
Contributor

@bmah888 bmah888 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for working with me on this! Tested with both forward and reverse tests successfully, merging shortly.

@bmah888 bmah888 merged commit abe95a9 into esnet:master Nov 22, 2024
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

iperf3 -O (--omit) to get more than 60 seconds omit time
2 participants