Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Small Jekyll YAML Metadata package #142

Merged
merged 2 commits into from
Dec 5, 2024
Merged

Small Jekyll YAML Metadata package #142

merged 2 commits into from
Dec 5, 2024

Conversation

nullnein
Copy link
Contributor

@nullnein nullnein commented Dec 5, 2024

Nothing much but I use the command nearly every day. Thought some other users may like it. Makes writing in an editor like iA writer much easier.

Copy link
Collaborator

@smeech smeech left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A single trigger for Jekyll users. No script, shell or potentially malicious code.

I have a couple of suggestions - the _manifest.yml one is particularly important, I'm afraid! Otherwise, it's good to go.

packages/jekyll-yaml/0.1.0/_manifest.yml Outdated Show resolved Hide resolved
packages/jekyll-yaml/0.1.0/README.md Show resolved Hide resolved
packages/jekyll-yaml/0.1.0/README.md Show resolved Hide resolved
@smeech smeech merged commit 6d216aa into espanso:main Dec 5, 2024
1 check passed
@smeech
Copy link
Collaborator

smeech commented Dec 5, 2024

I've merged the PR. It should appear in the repo quickly, and on the Hub in an hour or so.
We've had issues with incomplete uploads, so 🤞 !

@smeech
Copy link
Collaborator

smeech commented Dec 5, 2024

@smeech
Copy link
Collaborator

smeech commented Dec 5, 2024

No progress...

@arabello?

@arabello
Copy link

arabello commented Dec 5, 2024

It looks like no releases are found for the repository. The same command the CI runs also returns no release fund locally. Also, the static link https://github.com/espanso/hub/releases/download/v1.0.0/package_index.json used by the Hub Frontend returns no data.

I need to investigate further, I can't understand right away as I am not confident with espanso/hub. Did some major change happened recently?

@smeech
Copy link
Collaborator

smeech commented Dec 5, 2024

Would that be in https://github.com/espanso/hub-frontend?
@AucaCoyan updated some versions in the CI recently, but nothing else I can see.

@AucaCoyan
Copy link
Member

Yup, I deleted the release this afternoon thinking it wasn't used, and after some debugging in this problem I found that was the reason for the failure.
I restored the release, ran the CI job again and everything went fine!

@smeech
Copy link
Collaborator

smeech commented Dec 6, 2024

Thank you - successfully uploaded to the Hub.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants