Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix LEDs stuck on startup twinkle #148

Merged
merged 2 commits into from
Sep 26, 2024
Merged

Fix LEDs stuck on startup twinkle #148

merged 2 commits into from
Sep 26, 2024

Conversation

kbx81
Copy link
Member

@kbx81 kbx81 commented Sep 26, 2024

If there is a delay connecting to wifi, Improv BLE (and the captive portal) may start, activating the twinkle effect. If, however, wifi does connect after a delay, Improv will stop without triggering on_provisioned. This results in the LEDs getting stuck on the start-up effect and never advancing.

This PR corrects this behavior by adding the on_stop trigger to Improv, allowing the subsequent effects to be visible.

@kbx81 kbx81 requested a review from jlpouffier September 26, 2024 07:09
Copy link

Firmware built successfully! 🎉

Download and extract the firmware to install with https://web.esphome.io

Make sure to choose home-assistant-voice-esp32s3.factory.bin.

Copy link
Contributor

@jlpouffier jlpouffier left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

THX!

@kbx81 kbx81 enabled auto-merge (squash) September 26, 2024 07:22
@kbx81 kbx81 merged commit 6dda892 into dev Sep 26, 2024
4 checks passed
@kbx81 kbx81 deleted the 20240926-fix-stuck-effect branch September 26, 2024 07:30
Copy link

Firmware built successfully! 🎉

Download and extract the firmware to install with https://web.esphome.io

Make sure to choose home-assistant-voice-esp32s3.factory.bin.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants