Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Debounce Colour Change #154

Merged
merged 2 commits into from
Oct 11, 2024
Merged

Debounce Colour Change #154

merged 2 commits into from
Oct 11, 2024

Conversation

jlpouffier
Copy link
Contributor

The press-and-turn interaction was getting triggered intentionally, by simply pressing the button.

Now, if you want to change the colour on device, you need to press and make at least 3 "ticks" of the dial to initialize the feature.

It's basically a safeguard feature, so that we are sure that if people are entering this mode, it is on purpose.

@jlpouffier
Copy link
Contributor Author

@jesserockz I may need some help here.
It's failing on the media_player side even if I did not touched this component ;)

@balloob balloob marked this pull request as ready for review October 11, 2024 18:36
Copy link

Firmware built successfully! 🎉

Download and extract the firmware to install with https://web.esphome.io

Make sure to choose home-assistant-voice-esp32s3.factory.bin.

@kbx81 kbx81 merged commit 7f64fb5 into dev Oct 11, 2024
7 checks passed
@kbx81 kbx81 deleted the debounce-color-change branch October 11, 2024 18:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants