[nabu] Use speaker output instead of writing to I2S directly #163
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Firmware built successfully! 🎉 Download and extract the firmware to install with https://web.esphome.io Make sure to choose |
This was referenced Oct 17, 2024
kahrendt
force-pushed
the
kahrendt-20241016-use-speaker-output
branch
from
6aa779c to
54cfb9d
Compare
|
Firmware built successfully! 🎉 Download and extract the firmware to install with https://web.esphome.io Make sure to choose |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Outputs audio to a speaker component instead of directly writing to the I2S bus. Requires the merged changes in esphome/esphome#7605. It also modifies the voice assistant component to ensure the speaker code doesn't run, as it should handle all audio out via the media player.
This better compartmentalizes the component, as it will run on any future speaker components.
I will follow up with another PR to revert the external component branch to dev.