Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Kind of fix for etalab tiles #2

Closed
wants to merge 1 commit into from
Closed

Conversation

abulte
Copy link
Contributor

@abulte abulte commented Apr 14, 2020

This switches from data.map to a global var _map. The Etalab styles load successfully. There must be something left to adjust because layers don't show up, but it might be a good starting point.

PS: sorry for the huge diff but you have trailing spaces everywhere 😱 and my editor is configured to remove them. We should at some point (not right now) land on a common style guide / linter for javascript code. I like https://standardjs.com but airbnb or some other sane standard would be fine.

Capture d'écran 2020-04-14 16 49 13

@abulte abulte requested a review from JulienParis April 14, 2020 14:54
@JulienParis
Copy link
Contributor

JulienParis commented Apr 18, 2020

I succeded in fixing the bug + using the Etalab tiles thanks to your code : the global var _map is definitely working while putting the map object into the local data is not...

Meanwhile I added a lot of things to the mapboxGL component, + all the trailing spaces, so I'd prefer not merging this PR => cf #6

So the ES lintting will be for another PR, now that j_front is merged to master

That said the bug still in place after being able to use the Etalab tiles was because of some functions written under computed and had to be moved under methods ... If I remember it well

@JulienParis JulienParis added bug Something isn't working front labels Apr 18, 2020
@JulienParis JulienParis deleted the poc-fix-map-etalab branch April 24, 2020 10:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working front
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants