Multiple fixes on API Impot Particulier #606
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Use plain old rails validation
…ation label Not really required by default, this is a hack to displays it. Ref https://linear.app/pole-api/issue/DAT-727/dgfip-feedbacks-demo#comment-3e8fa06d
Build accurate models, with authorizations from previous stage.
We're talking about the next stage, not "a stage" which is not enough accurate here.
skelz0r
force-pushed
the
enhance/api-impot-part
branch
from
37eb692 to
0652c9a
Compare
skelz0r
requested review from
jbfeldis,
JeSuisUnCaillou,
Samuelfaure and
Isalafont
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ref https://linear.app/pole-api/issue/DAT-727