fix: use require.NoError instead of t.Fatal(err) in client package

[mmorel-35]

Description

This uses testify instead of testing for
With

require.NoError(t, err)

require.Error(t, err)

instead of

if err != nil {
    t.Fatal(err)
}


if err == nil {
    t.Fatal(err)
}

Related to #18972

[k8s-ci-robot]

Hi @mmorel-35. Thanks for your PR.

I'm waiting for a etcd-io member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

[codecov-commenter]

⚠️ Please install the to ensure uploads and comments are reliably processed by Codecov.

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 68.71%. Comparing base (17fb752) to head (da91de6).
Report is 11 commits behind head on main.

❗ Current head da91de6 differs from pull request most recent head 3343dc8

Please upload reports for the commit 3343dc8 to get more accurate results.

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files

see 24 files with indirect coverage changes

@@            Coverage Diff             @@
##             main   #18705      +/-   ##
==========================================
- Coverage   68.84%   68.71%   -0.13%     
==========================================
  Files         420      420              
  Lines       35540    35540              
==========================================
- Hits        24466    24421      -45     
- Misses       9651     9691      +40     
- Partials     1423     1428       +5     

---

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 17fb752...3343dc8. Read the comment docs.

[mmorel-35]

/assign @wenjiaswe

[ahrtr]

Thanks for the PR. Please try not raise huge PR. Please try to breakdown this PR, thx

[mmorel-35]

One PR per first level folder shall be enough ?

[ahrtr]

One PR per first level folder shall be enough ?

works for me

[ivanvc]

/ok-to-test

[ivanvc]

This looks good. Thanks for your pull request, @mmorel-35. Two files have changes that are not related to require.NoError():

1. client/v3/ctx_test.go
2. client/pkg/tlsutil/cipher_suites_test.go

I just wanted to point it out. It could be a minor nitpick, but if others think it's ok to include them in this PR, then this PR LGTM.

Thanks.

[ahrtr]

/test pull-etcd-integration-1-cpu-arm64

[ahrtr]

LGTM

Thanks

[ivanvc]

LGTM. Thanks, Matthieu!

[k8s-ci-robot]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: ahrtr, ivanvc, mmorel-35

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

• OWNERS [ahrtr]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment