Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: use testify instead of t.Fatal or t.Error in server package (part 1) #18971

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

fix: use testify instead of t.Fatal or t.Error in server package (part 1) #18971

wants to merge 1 commit into from

Conversation

mmorel-35
Copy link
Contributor

@mmorel-35 mmorel-35 commented Nov 30, 2024 •
edited
Loading

Description

This uses testify instead of testing for t.Fatal or t.Error calls in server package

Related to #18972

@k8s-ci-robot
Copy link

Hi @mmorel-35. Thanks for your PR.

I'm waiting for a etcd-io member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@mmorel-35 mmorel-35 mentioned this pull request Nov 30, 2024
Open
14 tasks
@codecov Codecov
Copy link

codecov bot commented Nov 30, 2024 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 68.80%. Comparing base (40b856e) to head (4228628).

Additional details and impacted files

see 26 files with indirect coverage changes

@@            Coverage Diff             @@
##             main   #18971      +/-   ##
==========================================
+ Coverage   68.77%   68.80%   +0.02%     
==========================================
  Files         420      420              
  Lines       35642    35642              
==========================================
+ Hits        24513    24522       +9     
+ Misses       9703     9693      -10     
- Partials     1426     1427       +1

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 40b856e...4228628. Read the comment docs.

@mmorel-35 mmorel-35 force-pushed the testifier/server branch 3 times, most recently from ea9e299 to 56d9dc3 Compare December 1, 2024 21:35
@ahrtr
Copy link
Member

ahrtr commented Dec 4, 2024

/ok-to-test

@mmorel-35 mmorel-35 force-pushed the testifier/server branch 3 times, most recently from bd41130 to c638757 Compare December 5, 2024 06:07
@mmorel-35
Copy link
Contributor Author

/test pull-etcd-verify

@k8s-ci-robot
Copy link

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: ahrtr, mmorel-35

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@mmorel-35 mmorel-35 force-pushed the testifier/server branch 2 times, most recently from 4ac9d68 to 68af9dd Compare December 12, 2024 06:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ahrtr ahrtr ahrtr approved these changes

Assignees
No one assigned
Labels
approved ok-to-test size/L
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@mmorel-35 @k8s-ci-robot @ahrtr