migrate --experimental-txn-mode-write-with-shared-buffer flag to feature gate.

[ishan16696]

This PR migrate --experimental-txn-mode-write-with-shared-buffer flag to use feature gate.

Fixes: #19063

Please read https://github.com/etcd-io/etcd/blob/main/CONTRIBUTING.md#contribution-flow.

[k8s-ci-robot]

Hi @ishan16696. Thanks for your PR.

I'm waiting for a etcd-io member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

[codecov]

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 68.82%. Comparing base (b5c620a) to head (c73b3d1).
Report is 19 commits behind head on main.

Additional details and impacted files

Files with missing lines	Coverage Δ
server/embed/config.go	79.43% <100.00%> (-0.04%)	⬇️
server/embed/etcd.go	75.73% <100.00%> (-0.05%)	⬇️
server/etcdmain/config.go	67.76% <ø> (ø)
server/etcdserver/server.go	82.27% <100.00%> (-0.15%)	⬇️
server/etcdserver/txn/txn.go	93.80% <100.00%> (+1.10%)	⬆️
server/etcdserver/v3_server.go	73.56% <100.00%> (+0.65%)	⬆️
server/features/etcd_features.go	60.00% <ø> (ø)

... and 20 files with indirect coverage changes

@@            Coverage Diff             @@
##             main   #19078      +/-   ##
==========================================
+ Coverage   68.81%   68.82%   +0.01%     
==========================================
  Files         420      420              
  Lines       35640    35640              
==========================================
+ Hits        24524    24530       +6     
+ Misses       9689     9684       -5     
+ Partials     1427     1426       -1     

---

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update b5c620a...c73b3d1. Read the comment docs.

[ahrtr]

/ok-to-test

[ishan16696]

/retest

[ishan16696]

/retest

[ishan16696]

Right now, TestV2SetMemberAttributes unit tests is failing in pkg/etcdserver/server_test.go due to server config is not containing feature flag, due to that it's got fatal error as func srv.NewUberApplier() requires a bool for this s.Cfg.ServerFeatureGate.Enabled(features.TxnModeWriteWithSharedBuffer).

	srv := &EtcdServer{
		lgMu:         new(sync.RWMutex),
		lg:           zaptest.NewLogger(t),
		v2store:      mockstore.NewRecorder(),
		cluster:      cl,
		consistIndex: cindex.NewConsistentIndex(be),
		w:            wait.New(),
	}

Will fix it.

[ahrtr]

Please follow #19053

• Add it into the deprecatedFlags, refer to migrate experimental-compact-hash-check-enabled to feature gate. #19053 (comment)
• Take care of the case of configFile

[siyuanfoundation]

A few nits, and +1 to @ahrtr comments.
Otherwise lgtm.

Thank you @ishan16696 Great work!

[ishan16696]

Take care of the case of configFile

I didn't get this, do I need to follow this PR: #19053 and make appropriate changes here ?

[ahrtr]

Take care of the case of configFile

I didn't get this, do I need to follow this PR: #19053 and make appropriate changes here ?

It has already been processed correctly, so no any action in this PR. Sorry for the confusion.

etcd/server/embed/config.go

Lines 842 to 844 in 9fa35e5

	for flg := range cfgMap {
	cfg.FlagsExplicitlySet[flg] = true
	}

Please resolve the minor comment in #19078 (comment) before we merge this PR. Thanks

[ahrtr]

Please also squash the commits.

[ishan16696]

Please resolve the minor comment in #19078 (comment) before we merge this PR. Thanks

done

Please also squash the commits.

done

[ishan16696]

/test pull-etcd-unit-test-386

[k8s-ci-robot]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: ahrtr, ishan16696, serathius

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

• OWNERS [ahrtr,serathius]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment