Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

holocene-changes: Link to latest upgrade script #1135

Merged
merged 1 commit into from
Nov 22, 2024

Conversation

sebastianst
Copy link
Member

The linked upgrade script was at the contracts tag. But we've actively developing the script, so we should always point to the latest script. The script itself checks out the contracts tag, so it's fine to always use the latest script.

The linked upgrade script was at the contracts tag. But we've actively developing the script, so we should always point to the latest script. The script itself checks out the contracts tag, so it's fine to always use the latest script.
@sebastianst sebastianst requested a review from a team as a code owner November 22, 2024 05:06
Copy link

netlify bot commented Nov 22, 2024

Deploy Preview for docs-optimism ready!

Name Link
🔨 Latest commit a71e1de
🔍 Latest deploy log https://app.netlify.com/sites/docs-optimism/deploys/674011711615f200087faf74
😎 Deploy Preview https://deploy-preview-1135--docs-optimism.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@sbvegan sbvegan merged commit 89962d0 into main Nov 22, 2024
8 of 9 checks passed
@sbvegan sbvegan deleted the seb/holocene-changes-scripts-link branch November 22, 2024 05:10
Copy link
Contributor

coderabbitai bot commented Nov 22, 2024

Caution

Review failed

The pull request is closed.

📝 Walkthrough

Walkthrough

The pull request introduces several modifications to the document titled "Preparing for Holocene Breaking Changes," aimed at enhancing clarity and detail regarding the Holocene network upgrade. Key changes include a revised introduction that emphasizes the importance of developer support during the upgrade process. A notable addition is a detailed upgrade script link, which is highlighted for chain operators to facilitate automated deployments and task generation.

The document structure has been adjusted to clarify that multiple updates to L1 contracts are required both before and after the Holocene activation. Additionally, the section for chain operators now specifies the necessity of upgrading their SystemConfig to the latest OP Contracts release for EIP-1559 configurability, with clearer recommendations on the timing of this upgrade.

For fault-proof enabled chains, the requirement to upgrade the op-program version is reiterated, and deployment details for the MIPS contract have been refined for consistency. Instructions for node operators have been expanded to include specific version numbers for op-node and op-geth, along with detailed steps for configuring the Holocene activation date.

Possibly related PRs

Suggested labels

do-not-merge

Suggested reviewers

  • cpengilly
  • sbvegan

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

❤️ Share
🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>, please review it.
    • Generate unit testing code for this file.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai generate unit testing code for this file.
    • @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
    • @coderabbitai read src/utils.ts and generate unit testing code.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
    • @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai full review to do a full review from scratch and review all the files again.
  • @coderabbitai summary to regenerate the summary of the PR.
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
  • @coderabbitai help to get help.

Other keywords and placeholders

  • Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
  • Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
  • Add @coderabbitai anywhere in the PR title to generate the title automatically.

Documentation and Community

  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants