Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(isthmus): l2tol1 message passer storage root #3

Open
wants to merge 26 commits into
base: isthmus-devnet-0
Choose a base branch
from

Conversation

emhane
Copy link
Member

@emhane emhane commented Dec 13, 2024

Description

Closes #4

Block building
  • Skips committing Shanghai withdrawals, instead debug asserts withdrawals in block body is empty.
  • Computes the storage root of l2tol1-message-passer contract in block building, and writes to withdrawals root field of block.
Block validation in live-sync
  • Decouples checking empty withdrawals list from checking empty withdrawals root - only checks empty withdrawals root if isthmus is not active.
  • Adds access to database to previously stateless block consensus validation. Checks withdrawals root of block (aka l2tol1-msg-passer storage root) against loaded storage root of the predeploy.
Block validation in pipeline-sync
  • Out of scope of this pr

Tests

Additional context

  • Check against storage root not possible in pipeline sync (cc @mattsse)

Metadata

@emhane emhane added the B-isthmus-devnet-0 Related to isthmus-devnet-0 label Dec 13, 2024
@emhane emhane closed this Dec 13, 2024
@emhane emhane force-pushed the emhane/storage-root-isthmus branch from 453a2c8 to 2690d7a Compare December 13, 2024 19:04
@emhane emhane reopened this Dec 13, 2024
@emhane emhane force-pushed the emhane/storage-root-isthmus branch from 2aba470 to 4799c1f Compare December 13, 2024 19:24
crates/optimism/consensus/src/error.rs Show resolved Hide resolved
crates/optimism/consensus/src/validation/canyon.rs Outdated Show resolved Hide resolved
crates/optimism/consensus/src/validation/isthmus.rs Outdated Show resolved Hide resolved
crates/optimism/consensus/src/validation/isthmus.rs Outdated Show resolved Hide resolved
crates/optimism/payload/src/builder.rs Outdated Show resolved Hide resolved
@emhane emhane requested a review from vdamle December 17, 2024 23:50
@emhane emhane force-pushed the emhane/storage-root-isthmus branch from e9894cb to 673ae2e Compare December 19, 2024 02:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
B-isthmus-devnet-0 Related to isthmus-devnet-0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants