feat: add dependency set check to L2ToL2CDM #13019
Merged
+55
−5
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
/ci authorize e3ed942 |
Merged
via the queue into
ethereum-optimism:develop
with commit Nov 21, 2024
ccb544d
49 checks passed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Add a check in the
L2ToL2CrossDomainMessengerto prevent messages from being sent to the wrong destination chain. It will validate that the destination chain ID is included in the dependency set.Tests
Add a new test to
L2ToL2CrossDomainMessengerAdditional context
Rationale: ethereum-optimism/specs#460
Metadata
Closes #13017