Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: remove proxy implementation for OPCM contract #13531

Open
wants to merge 1 commit into
base: develop
Choose a base branch
from

Conversation

CreeptoGengar
Copy link

@CreeptoGengar CreeptoGengar commented Dec 25, 2024

Description

This pull request removes the proxy implementation for the OPContractsManager (OPCM) contract in the Bedrock deployment script. The changes replace the reference to a previously deployed OPContractsManager with the creation of a new instance of the contract directly within the deployment process.

Tests

No specific tests were added for this change as it directly updates the deployment script. However, deployment processes should be revalidated to ensure that the removal of the proxy does not introduce regressions or disrupt existing deployment workflows.

Additional Context

  • The updated logic ensures that the OPContractsManager is deployed afresh with each invocation of the script, aligning with deployment requirements for Bedrock.
  • This change simplifies the deployment flow by removing an additional dependency on the proxy.

Metadata


Notes for Maintainers

Allow edits by maintainers: ✅
This change follows the contributing guidelines and aims to streamline the Bedrock contract deployment process.

@CreeptoGengar CreeptoGengar requested a review from a team as a code owner December 25, 2024 05:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

OPCM is defined as proxied in Deploy.s.sol
1 participant