Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: fix labelling of addresses in Setup.sol #13533

Open
wants to merge 1 commit into
base: develop
Choose a base branch
from

Conversation

DeVikingMark
Copy link

Description

Fixes address labeling issue in Setup.sol where proxy addresses were labeled twice. Changes include:

  • Remove duplicate labels for proxy contracts
  • Keep only "Proxy" suffix labels for proxy contracts
  • Maintain special labels for non-proxy contracts (AddressManager, L1CrossDomainMessenger_aliased)

This makes address labeling more consistent and eliminates confusion during debugging.

Tests

Existing tests cover these changes since:

  • Changes only affect debug labels
  • Do not modify code functionality
  • Do not impact contract logic
  • Used only in test environment

Additional context

These changes improve debugging by making contract labels clearer and eliminating confusion between proxies and their implementations.

Metadata

@DeVikingMark DeVikingMark requested a review from a team as a code owner December 25, 2024 17:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Fix labelling of addresses in Setup.sol
1 participant