Update EIP-2537: Added MSM and pairings precompiles without subgroup checks #8965
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
Marchhill
commented
Oct 15, 2024
Marchhill
commented
- Removed redundant MUL operations to minimise increase in precompile count (as in Update EIP-2537: Remove redundant MUL precompiles #8945).
- Added 'unsafe' MSM and pairings precompiles that do not have subgroup checks.
- todo: Determine relative pricing of precompiles with and without subgroup checks
github-actions
bot
added
c-update
File
|
|
|
@Marchhill may you motivate these proposed changes ? |
Added some motivation for unsafe precompiles. |
16 tasks
chfast
suggested changes
Oct 22, 2024
| - BLS12_PAIRING_CHECK - to perform a pairing operations between a set of *pairs* of (G1, G2) points a gas cost formula defined in the corresponding section | ||
| - BLS12_PAIRING_CHECK_UNSAFE - identical to BLS12_PAIRING_CHECK except that subgroup checks will **not** be performed. |
There was a problem hiding this comment.
I think this is no-starter. How are you going to define this operation for points outside of the main prime subgroup?
There was a problem hiding this comment.
totally agree with @chfast here!!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.