Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(types,tests): EIP-7685 fixes for devnet-5 #990

Merged
merged 4 commits into from
Dec 4, 2024
Merged

Conversation

marioevz
Copy link
Member

@marioevz marioevz commented Dec 4, 2024

🗒️ Description

Addresses changes in ethereum/EIPs#8989 and ethereum/execution-apis#599 for devnet-5 by removing the empty requests from the requests list in the computation of the commitment.

Requires ethereum/execution-specs#1046

🔗 Related Issues

#956

✅ Checklist

  • All: Set appropriate labels for the changes.
  • All: Considered squashing commits to improve commit history.
  • All: Added an entry to CHANGELOG.md.
  • All: Considered updating the online docs in the ./docs/ directory.
  • Tests: All converted JSON/YML tests from ethereum/tests have been added to converted-ethereum-tests.txt.
  • Tests: A PR with removal of converted JSON/YML tests from ethereum/tests have been opened.
  • Tests: Included the type and version of evm t8n tool used to locally execute test cases: e.g., ref with commit hash or geth 1.13.1-stable-3f40e65.
  • Tests: Ran mkdocs serve locally and verified the auto-generated docs for new tests in the Test Case Reference are correctly formatted.

@marioevz marioevz added scope:forks Scope: ethereum_test_forks package scope:tests Scope: Test cases scope:fw Scope: Framework (evm|tools|forks|pytest) labels Dec 4, 2024
Copy link
Collaborator

@spencer-tb spencer-tb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Amazing! Empty hash LGTM!

Taking a look at the tests :D

@spencer-tb spencer-tb merged commit 5a40172 into main Dec 4, 2024
5 checks passed
@spencer-tb spencer-tb deleted the eip-7685-devnet-5 branch December 4, 2024 10:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
scope:forks Scope: ethereum_test_forks package scope:fw Scope: Framework (evm|tools|forks|pytest) scope:tests Scope: Test cases
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants