-
Notifications
You must be signed in to change notification settings - Fork 20.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
eth/filters: eth_getLogs fast exit for invalid block range #28386
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Seems reasonable to me, some nits though
@holiman fixed it, please take another look. |
Signed-off-by: jsvisa <[email protected]>
Signed-off-by: jsvisa <[email protected]>
Signed-off-by: jsvisa <[email protected]>
Signed-off-by: jsvisa <[email protected]>
Signed-off-by: jsvisa <[email protected]>
Signed-off-by: jsvisa <[email protected]>
Signed-off-by: jsvisa <[email protected]>
This reverts commit a15f45c. Signed-off-by: jsvisa <[email protected]>
This reverts commit 4bd9908. Signed-off-by: jsvisa <[email protected]>
This reverts commit aa50100. Signed-off-by: jsvisa <[email protected]>
This reverts commit ed3b1e6. Signed-off-by: jsvisa <[email protected]>
Signed-off-by: jsvisa <[email protected]>
85f9acf
to
ed51166
Compare
Blocked on ethereum/execution-apis#480 being merged. |
@s1na @jsvisa Could you generalize the error message? Would like to implement block range limit for Something like |
@kaliubuntu0206 I think this error message would work for us too. However generally I'd like if we could standardize error codes instead of error messages. It's perfectly reasonable that clients would return different messages (e.g. some with more context or less). |
Signed-off-by: jsvisa <[email protected]>
…thereum#28386)" This reverts commit df4c930.
…thereum#28386)" This reverts commit df4c930.
We can quickly exit if the from > to in
eth_getLogs
request.BTW, currently for
eth_newFilter
, if from>to, then the RPC returns an error, but no error foreth_getLogs
, should we need to unify their behavior, or let it go?