Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

all: exclude empty outputs in requests commitment #30670

Merged
merged 6 commits into from
Nov 28, 2024

Conversation

fjl
Copy link
Contributor

@fjl fjl commented Oct 24, 2024

@fjl fjl added the prague label Oct 24, 2024
@fjl fjl changed the title all: remove empty items in requests commitment all: exclude empty outputs in requests commitment Oct 24, 2024
@lightclient lightclient self-assigned this Oct 30, 2024
@fjl fjl requested a review from s1na as a code owner October 31, 2024 20:20
@fjl
Copy link
Contributor Author

fjl commented Oct 31, 2024

@lightclient PTAL

@fjl fjl force-pushed the core-eip-7685-devnet-5 branch from 8434f6c to 41cd829 Compare November 26, 2024 15:26
@fjl
Copy link
Contributor Author

fjl commented Nov 26, 2024

Should be OK to merge now that EIP changes are in.

Copy link
Member

@MariusVanDerWijden MariusVanDerWijden left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@fjl fjl merged commit db8eed8 into ethereum:master Nov 28, 2024
3 checks passed
@fjl fjl added this to the 1.14.13 milestone Nov 28, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants