fix: update dependencies and add openssl vendored #1466
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
njgheorghita
commented
Sep 19, 2024
njgheorghita
commented
Sep 19, 2024
Cargo.toml
Outdated
| @@ -100,6 +101,7 @@ jsonrpsee = "0.20.0" | |||
| keccak-hash = "0.10.0" | |||
| lazy_static = "1.4.0" | |||
| light-client = { path = "light-client" } | |||
| openssl = { version = "0.10.66", features = ["vendored"]} | |||
There was a problem hiding this comment.
The main downside of this solution is that openssl is a fairly large library, but I was unable to figure out an alternative solution (see other comment) ... but I'm open to any ideas
There was a problem hiding this comment.
the feature native-tls-vendored should be enabled for reqwest and openssl = { version = "0.10.66", features = ["vendored"]} should be removed I believe
There was a problem hiding this comment.
Nice, that seems to work fine locally!
There was a problem hiding this comment.
Could you try
reqwest = { version = "0.12.7", default-features = false, features = ["native-tls-vendored", "rustls-tls", "json"] }
changing this to
reqwest = { version = "0.12.7", default-features = false, features = ["rustls-tls-native-roots", "json"] }
njgheorghita
force-pushed
the
deps
branch
2 times, most recently
from
5e2aeb1 to
be021f3
Compare
1 task
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What was wrong?
Building the releases is broken (https://github.com/ethereum/trin/actions/runs/10947101080/job/30395908924). IIUC, it probably had something to do with the changes in dependencies in #1448
I've tested these changes locally, and was able to cross compile the release binary, so I'm fairly confident that this will resolve the issue in our broken release workflow
How was it fixed?
rustcversion in toolchain & updated out of date libraries that wouldn't compilevendoredversion ofopenssllibraryTo-Do