fixed _.minBy lodash version problem with the datatables #294
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* update the latest datatables * fixup some css styling
|
So this issue is already fixed on #146 right? 😄 |
|
yes. PR #146 include datatables.js update and have no lodash.js related |
ghost
approved these changes
Mar 22, 2019
|
Rebase your PR! |
|
Just a small note to fix it later: |
ghost
suggested changes
Mar 29, 2019
ghost
reviewed
Mar 29, 2019
| @@ -1,525 +1 @@ | |||
| /* | |||
| @@ -130,7 +130,7 @@ BlocksApp.config(['$stateProvider', '$urlRouterProvider', function($stateProvide | |||
| insertBefore: '#ng_load_plugins_before', // load the above css files before '#ng_load_plugins_before' | |||
| files: [ | |||
| '/js/controllers/AddressController.js', | |||
| '/plugins/datatables/datatables.min.css', | |||
| //'/plugins/datatables/datatables.min.css', | |||
There was a problem hiding this comment.
Why did you excluded the datatables.min.css?
| @@ -62,7 +62,7 @@ | |||
| <div class="tab-content"> | |||
| <div class="tab-pane table-container" ng-class="{active: activeTab == 'tab_addr_1' || !activeTab}" id="tab_addr_1"><!-- Datatable tab --> | |||
|
|
|||
| <table class="table table-striped table-hover" id="table_txs" style="table-layout:fixed;width: 98% !important;"> | |||
| <table class="table table-striped table-bordered table-hover" id="table_txs" style="table-layout:fixed;width: 98% !important;"> | |||
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
this PR fix some annoying bug with the dataTables plugin with the lodash
_.minBy_.minBydoes not supported by the lodash v3.x