Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Explorer patch ( mongoose + gulpify + small cleanup ) #305

Merged
merged 10 commits into from Apr 15, 2019
Merged

Explorer patch ( mongoose + gulpify + small cleanup ) #305

merged 10 commits into from Apr 15, 2019

Conversation

ghost
Copy link

@ghost ghost commented Apr 2, 2019

phyro and others added 9 commits March 27, 2019 10:25
 * improve documentation
 * update solc and mongoose version
 * update db.js
 * drop tools/price.js from docker-compose.yml
 * author tag no longer required by search engine
 * fix footer.html
 * minify css
 * renamed custom.css to etc-explorer.css
 * update footer.html hyperlinks to open on new tab
Remove author from html tags
 * gulpified plugins
 * gulpified fonts
 * gulpified eslint
 * cleanup fonts & plugins
 * based on @hackmod's edit
cleanup: remove unnecessary files
Copy link
Member

@phyro phyro left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Apart from the comments this seems fine but I'm not familiar with gulpify. Someone else with the understanding of it should take a look

README.md Show resolved Hide resolved
config.example.json Show resolved Hide resolved
docker-compose.yml Show resolved Hide resolved
Copy link
Member

@mikeyb mikeyb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1 looks good to me. as discussed will be nice to get the jquery/datatables packages updated soon

@mikeyb mikeyb requested a review from realcodywburns April 9, 2019 14:47
* update mongoose package version
* update web3-explorer package version
* update mocha package version
Copy link
Member

@mikeyb mikeyb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1

@phyro phyro merged commit 6429d74 into ethereumclassic:dev Apr 15, 2019
@hackmod hackmod mentioned this pull request Oct 4, 2019
7 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants