-
Notifications
You must be signed in to change notification settings - Fork 252
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Explorer patch ( mongoose + gulpify + small cleanup ) #305
Conversation
ghost
commented
Apr 2, 2019
•
edited by ghost
Loading
edited by ghost
- Updated mongoose version ( https://github.com/btenterprise2020/etc-explorer/pull/16 ).
- Applied gulp for easier management ( https://github.com/btenterprise2020/etc-explorer/pull/18 ).
- Minor cleanup ( https://github.com/btenterprise2020/etc-explorer/pull/21 ).
- Document improvement.
Backport: Dev into Master
* improve documentation * update solc and mongoose version * update db.js * drop tools/price.js from docker-compose.yml
Update mongoose version
* author tag no longer required by search engine * fix footer.html * minify css * renamed custom.css to etc-explorer.css * update footer.html hyperlinks to open on new tab
Remove author from html tags
* gulpified plugins * gulpified fonts * gulpified eslint * cleanup fonts & plugins * based on @hackmod's edit
Gulpified plugins
cleanup: remove unnecessary files
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Apart from the comments this seems fine but I'm not familiar with gulpify. Someone else with the understanding of it should take a look
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
+1 looks good to me. as discussed will be nice to get the jquery/datatables packages updated soon
* update mongoose package version * update web3-explorer package version * update mocha package version
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
+1