-
Notifications
You must be signed in to change notification settings - Fork 772
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add dataGasUsed to txReceipt and result #2620
Conversation
Codecov Report
Additional details and impacted files
Flags with carried forward coverage won't be shown. Click here to find out more. |
b153024
to
ce9d6a2
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm
I vote we don't merge this for now. It shouldn't be too much work to rebase it if'/when the corresponding spec update happens so no point in adding it now when there's no real world use for it. |
…-to-receipt/txresult
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm!
This adds the
dataGasUsed
field to theTxResult
and also adds a new receipt type for blob transactions which includes the DataGasUsed andDataGasPrice
values in the receipt.