Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Implement EIP6780: SELFDESTRUCT only in same transaction #2733

Closed
wants to merge 37 commits into from
Closed

Implement EIP6780: SELFDESTRUCT only in same transaction #2733

wants to merge 37 commits into from

Conversation

jochem-brouwer
Copy link
Member

@jochem-brouwer jochem-brouwer commented May 27, 2023 •
edited
Loading

Follow-up of #2612

Implements https://eips.ethereum.org/EIPS/eip-6780

This EIP is currently included in Cancun per ethereum/execution-specs#763

Note: target branch is cleanup-statemanager-v2 (PR #2702), do not merge yet. (But ready for review)

@jochem-brouwer
evm: move touched accounts into evm from stateManager
d915d07
@jochem-brouwer
evm: use evmJournal commit/revert
6bd0c27
@jochem-brouwer
add deleteAccount
558cc6b
@jochem-brouwer
vm: fix build
73858dc
@jochem-brouwer
vm: fix test runner
95cd78a
@jochem-brouwer
evmJournal: prepare for using maps to start using warm addresses/slots
600bee9
@jochem-brouwer
evmJournal: eip2929 preparations
2ba50a7
@jochem-brouwer
vm: fix build and logic
d8de4a7
@jochem-brouwer
stateManager: mark methods as not implemented
ee6dfba
@jochem-brouwer
stash work
fc7f6b8
@jochem-brouwer
evm: update journal logic [no ci]
003b8b7
@jochem-brouwer
evm: update journal
4f7e27d
@jochem-brouwer
vm/evm/common: update journaler
915fa48
@jochem-brouwer
evm: journal fixes
e846c93
@jochem-brouwer
evm/vm: journaling fixes regarding checkpoitn logic [no ci]
c9621c3
@jochem-brouwer
test setup remove me
97b65c9
@jochem-brouwer
Merge branch 'master' into cleanup-statemanager-v2
ce97405
@jochem-brouwer
evm: journal fix
a399392
@jochem-brouwer
evm: journal cleanup and fixes
9c81cd6
@jochem-brouwer
vm: fix state tests
2445acd
@jochem-brouwer
vm: add TODO
bbc888a
@jochem-brouwer
Merge branch 'master' into cleanup-statemanager-v2
767345b
@jochem-brouwer
common/state/evm/vm: implement originalStorageCache
37ed1fc
@jochem-brouwer
Merge branch 'master' into cleanup-statemanager-v2
7fd5a57
@jochem-brouwer
statemanager/evm/vm: remove access list logic from statemanager
8908ee7
@jochem-brouwer
cleanup tests
4643ec3
@jochem-brouwer
vm: fix tests
5f02684
@jochem-brouwer
vm: fix tests
0b8da8d
@jochem-brouwer
evm: fix tests
295773c
@jochem-brouwer
statemanager: fix tests
0f1d276
@jochem-brouwer jochem-brouwer mentioned this pull request May 27, 2023
Closed
@jochem-brouwer jochem-brouwer changed the base branch from cleanup-statemanager-v2 to master May 27, 2023 13:55
@jochem-brouwer jochem-brouwer changed the base branch from master to cleanup-statemanager-v2 May 27, 2023 13:55
@jochem-brouwer jochem-brouwer marked this pull request as draft May 27, 2023 13:56
@codecov
Copy link

codecov bot commented May 27, 2023 •
edited
Loading

Codecov Report

Merging #2733 (e803f8b) into cleanup-statemanager-v2 (fb2b83a) will increase coverage by 0.26%.
The diff coverage is 79.59%.

Additional details and impacted files

Impacted file tree graph

Flag Coverage Δ
block 90.82% <ø> (ø)
blockchain 90.72% <ø> (ø)
client 86.81% <ø> (ø)
common 97.00% <100.00%> (+<0.01%) ⬆️
devp2p 89.23% <ø> (?)
ethash ∅ <ø> (∅)
evm 79.99% <75.60%> (-0.03%) ⬇️
rlp ∅ <ø> (∅)
statemanager 86.74% <100.00%> (+<0.01%) ⬆️
trie 90.21% <ø> (+0.28%) ⬆️
tx 95.76% <ø> (ø)
util 81.13% <ø> (ø)
vm 81.12% <100.00%> (+0.05%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

@jochem-brouwer jochem-brouwer changed the title Implement EIP6780 Implement EIP6780: SELFDESTRUCT only in same transaction May 27, 2023
Base automatically changed from cleanup-statemanager-v2 to master June 1, 2023 20:31
@jochem-brouwer jochem-brouwer mentioned this pull request Jun 10, 2023
Merged
@jochem-brouwer
Copy link
Member Author

jochem-brouwer commented Jun 10, 2023 •
edited
Loading

Followed by #2771

@holgerd77 holgerd77 deleted the eip6780-v2 branch July 11, 2024 08:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
package: common package: evm package: statemanager package: vm PR/Issue state: blocked PR state: do-not-merge PR state: needs review
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@jochem-brouwer