Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Browser client updates #476

Merged
merged 2 commits into from
Oct 7, 2023
Merged

Browser client updates #476

merged 2 commits into from
Oct 7, 2023

Conversation

acolytec3
Copy link
Collaborator

@acolytec3 acolytec3 commented Oct 6, 2023

This PR is a potentially temporary measure to speed up our dev workflow

  • Renames client package to ui (we probably could use a better name but client is too close to cli)
  • Changes the name of the build script in browser-client and ui to something other than build so we don't rebuild the browser clients every single time we make a change (which speeds up installs/builds generally ). When we start working closely on browser-client again, it might make sense to change this back.

Copy link
Collaborator

@ScottyPoi ScottyPoi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

good call with the 'build' scripts
🆙 dev ex

@ScottyPoi ScottyPoi merged commit 71c581e into master Oct 7, 2023
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants