Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Move all offers to gossipManager #689

Merged
merged 9 commits into from
Dec 13, 2024
Merged

Move all offers to gossipManager #689

merged 9 commits into from
Dec 13, 2024

Conversation

acolytec3
Copy link
Collaborator

This moves all sendOffer calls into the gossipManager class and makes it a property of the BaseNetwork class. This should help to ensure we only have one outbound uTP stream open to another peer at a time.

ScottyPoi
ScottyPoi approved these changes Dec 13, 2024
View reviewed changes
Copy link
Collaborator

@ScottyPoi ScottyPoi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Approved to merge if we have run this through the hive tests as well

@ScottyPoi ScottyPoi merged commit c652435 into master Dec 13, 2024
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ScottyPoi ScottyPoi ScottyPoi approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@acolytec3 @ScottyPoi