Use INodeAddress type in message handling #693
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes issue caused by #682 / #684
Message handling must use
INodeAddress
type, sinceonTalkRequest
events fromdiscv5
do not always contain anENR
.All network message handlers were updated to use
INodeAddress
, which is all that is needed forsendTalkResponse
.This gets a little tricky when a new
uTP
request is created. AlluTP
messages happen viatalkReq
, which requires anENR
to send. However, there are times when theuTP
request needs to be instantiated before the peer'sENR
has become available. So a newuTP
request can be created using eitherINodeAddress
orENR
. In cases where we use theINodeAddress
, we optimistically hope that by the time we need to send the firstuTP
packet, the peer'sENR
has become available.