Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes an issue where
discv5
was not being instantiated with configuration options set duringPortalNetwork.create
.We define a
defaultConfig
object forPortalNetwork.create
, and modify it using args passed to the function like this:const config = { ...defaultConfig, ...opts.config }
However, this was not effectively combining configuration options set specifically for discv5 which were in nested object
config.config
.To fix this, we add this line after the one above:
config.config = { ...defaultConfig.config, ...opts.config.config }
This solves the issue, and now
discv5
starts with the expected configuration.