Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add handling sklearn version in OneHotEncoderTransform and HierarchicalClustering #529

Merged
merged 6 commits into from
Dec 18, 2024

Conversation

d-a-bunin
Copy link
Collaborator

Before submitting (must do checklist)

  • Did you read the contribution guide?
  • Did you update the docs? We use Numpy format for all the methods and classes.
  • Did you write any new necessary tests?
  • Did you update the CHANGELOG?

Proposed Changes

Add workaroud for working in sklearn >= 1.4.

Closing issues

Closes #497 and #516

@d-a-bunin d-a-bunin self-assigned this Dec 16, 2024
Copy link

github-actions bot commented Dec 16, 2024

🚀 Deployed on https://deploy-preview-529--etna-docs.netlify.app

@github-actions github-actions bot temporarily deployed to pull request December 16, 2024 09:53 Inactive
Copy link

codecov bot commented Dec 16, 2024

Codecov Report

Attention: Patch coverage is 83.33333% with 2 lines in your changes missing coverage. Please review.

Project coverage is 90.36%. Comparing base (064e645) to head (8ab9fae).
Report is 1 commits behind head on master.

Files with missing lines Patch % Lines
etna/clustering/hierarchical/base.py 80.00% 1 Missing ⚠️
etna/transforms/encoders/categorical.py 85.71% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master     #529      +/-   ##
==========================================
- Coverage   90.38%   90.36%   -0.03%     
==========================================
  Files         256      256              
  Lines       17292    17303      +11     
==========================================
+ Hits        15630    15635       +5     
- Misses       1662     1668       +6     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@d-a-bunin d-a-bunin requested a review from egoriyaa December 17, 2024 07:54
poetry.lock Outdated
@@ -4740,6 +4740,41 @@ docs = ["Pillow (>=7.1.2)", "matplotlib (>=2.2.3)", "memory-profiler (>=0.57.0)"
examples = ["matplotlib (>=2.2.3)", "pandas (>=0.25.0)", "scikit-image (>=0.14.5)", "seaborn (>=0.9.0)"]
tests = ["black (>=21.6b0)", "flake8 (>=3.8.2)", "matplotlib (>=2.2.3)", "mypy (>=0.770)", "pandas (>=0.25.0)", "pyamg (>=4.0.0)", "pytest (>=5.0.1)", "pytest-cov (>=2.9.0)", "scikit-image (>=0.14.5)"]

[[package]]
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I can't understand why poetry is doing this with scipy and statsmodels...

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This happenned when I ran poetry update scikit-learn.

Copy link
Collaborator Author

@d-a-bunin d-a-bunin Dec 18, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The strange thing is that it added two versions of scipy here. But in a current master we have two versions of statsmodels.

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I have a suspicion that it uses two different versions for different python versions. I'll probably revert update in lock in this PR.

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why do you run poetry update scikit-learn?

@egoriyaa
Copy link
Collaborator

Changelog?

@github-actions github-actions bot temporarily deployed to pull request December 18, 2024 06:48 Inactive
@github-actions github-actions bot temporarily deployed to pull request December 18, 2024 07:50 Inactive
@github-actions github-actions bot temporarily deployed to pull request December 18, 2024 08:26 Inactive
@d-a-bunin d-a-bunin merged commit f527fdb into master Dec 18, 2024
17 checks passed
@d-a-bunin d-a-bunin deleted the issue-497 branch December 18, 2024 09:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[BUG] OneHotEncoderTransform got an unexpected keyword argument 'sparse'
2 participants