-
Notifications
You must be signed in to change notification settings - Fork 8
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add handling sklearn version in OneHotEncoderTransform
and HierarchicalClustering
#529
Conversation
…rchicalClustering
🚀 Deployed on https://deploy-preview-529--etna-docs.netlify.app |
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #529 +/- ##
==========================================
- Coverage 90.38% 90.36% -0.03%
==========================================
Files 256 256
Lines 17292 17303 +11
==========================================
+ Hits 15630 15635 +5
- Misses 1662 1668 +6 ☔ View full report in Codecov by Sentry. |
poetry.lock
Outdated
@@ -4740,6 +4740,41 @@ docs = ["Pillow (>=7.1.2)", "matplotlib (>=2.2.3)", "memory-profiler (>=0.57.0)" | |||
examples = ["matplotlib (>=2.2.3)", "pandas (>=0.25.0)", "scikit-image (>=0.14.5)", "seaborn (>=0.9.0)"] | |||
tests = ["black (>=21.6b0)", "flake8 (>=3.8.2)", "matplotlib (>=2.2.3)", "mypy (>=0.770)", "pandas (>=0.25.0)", "pyamg (>=4.0.0)", "pytest (>=5.0.1)", "pytest-cov (>=2.9.0)", "scikit-image (>=0.14.5)"] | |||
|
|||
[[package]] |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I can't understand why poetry is doing this with scipy
and statsmodels
...
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This happenned when I ran poetry update scikit-learn
.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The strange thing is that it added two versions of scipy
here. But in a current master
we have two versions of statsmodels
.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I have a suspicion that it uses two different versions for different python versions. I'll probably revert update in lock in this PR.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Why do you run poetry update scikit-learn
?
Changelog? |
Before submitting (must do checklist)
Proposed Changes
Add workaroud for working in sklearn >= 1.4.
Closing issues
Closes #497 and #516