Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Created dogs.md #6

Closed
wants to merge 2 commits into from
Closed

Created dogs.md #6

wants to merge 2 commits into from

Conversation

soulspark666
Copy link
Contributor

Add ASCII art for dogs for issue #1

@eugeniumegherea
Copy link
Owner

Thanks for PR
Please add dogs.md file to the index (add link in README to the file)

@soulspark666
Copy link
Contributor Author

soulspark666 commented Oct 9, 2018 •
edited
Loading

Added dogs.md and memes.md to Readme.md in #7

@eugeniumegherea
Copy link
Owner

Hey,
there's something wrong with the PR's. First, you shouldn't have made another PR with fixes. You could simply commit and push on patch-1 branch (here). Second, if you take a look at your patch-2 branch, there are no memes.md and dogs.md files. Probably you haven't added them to commit. I will close another PR as it is duplicate and you try commiting the fixes again.
Thanks

@eugeniumegherea eugeniumegherea mentioned this pull request Oct 10, 2018
Closed
@soulspark666 soulspark666 deleted the patch-1 branch October 11, 2018 12:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@soulspark666 @eugeniumegherea