Stripe paymentelement migration #345
Conversation
Untested, WIP.
| amount: 1337, | ||
| fields: { | ||
| billingDetails: 'never', | ||
| } |
There was a problem hiding this comment.
Hi @ultimate-tester ,
Whoops. We can not hardcoded the amount and currency like this. It must be from the cart
There was a problem hiding this comment.
Would you be able to help me with this? My experience with React is limited so I don't have a clue on how to add these fields into context :(
There was a problem hiding this comment.
Sure, I will take care of it. Please give me sometime
|
I see this PR is merged but I cannot see that the pending task was resolved (I'm on my phone at the moment). Did you double check those hardcoded variables for e.g. amount? |
|
Hi @ultimate-tester , I merged your PR to a feature branch and will continue fixing the issue there. Thanks |
PR Checklist
Please check if your PR fulfills the following requirements:
PR Type
What kind of change does this PR introduce?
What is the current behavior?
Currently Stripe is only utilized for card payments and nothing more.
Issue Number: 344
What is the new behavior?
This PR expands it to the full range of payment methods that Stripe offers (e.g. iDeal, WeChat, Google Pay, Apple Pay, etc.). It does this by replacing the card element by a payment element where user can select their preferred payment method.
Does this PR introduce a breaking change?
Other information
This is a tested but maybe not final version of the Payment Element migration