Issue # 142 fix #377
Merged
Issue # 142 fix #377
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
stripe web hook returned amount data is integer of how many cents, we store in dollars with 4 decimal points in postgres database
use zero-decimal-currencies to fix stripe web hook amount inconsistency. For non zero-decimal-currencies, amount is divided by 100 before insert into database, otherwise, original paymentIntent.amount is saved
|
this fix uses 'zero-decimal-currencies' package display function to convert web hook call back amount to be the correct amount before insert into databases. (It ignores three decimal currencies, can be fixed by patch to that package) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR Checklist
Please check if your PR fulfills the following requirements:
PR Type
What kind of change does this PR introduce?
What is the current behavior?
Issue Number: #142
What is the new behavior?
In the webhook of stripe payment, the amount saved is dependent on if the currency charged is a "zero decimal currency", according to stripe.
Does this PR introduce a breaking change?
Other information