Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix Modal Dialog References #225

Merged
merged 7 commits into from
Mar 17, 2024
Merged

Conversation

pkayokay
Copy link
Contributor

@pkayokay pkayokay commented Mar 17, 2024

  • Fixes the modal due to a target mismatch on the example site.
  • Updates the modal example
  • Adds modal tests

@excid3
Copy link
Owner

excid3 commented Mar 17, 2024

I've never been able to get this test suite running reliably unfortunately. Would love to get that figured out. They seem to pass more reliable on CI than locally even.

@excid3 excid3 merged commit 0b726c7 into excid3:main Mar 17, 2024
1 check failed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants