Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

🔧 Improve typing for MarkdownIt.add_render_rule #287

Open
wants to merge 5 commits into
base: master
Choose a base branch
from

Conversation

chrisjsewell
Copy link
Member

Make the function signtature more explicit

@codecov
Copy link

codecov bot commented Jun 5, 2023

Codecov Report

Attention: Patch coverage is 91.66667% with 2 lines in your changes missing coverage. Please review.

Project coverage is 95.14%. Comparing base (bee6d19) to head (a43a87b).
Report is 18 commits behind head on master.

Files with missing lines Patch % Lines
markdown_it/main.py 50.00% 1 Missing ⚠️
markdown_it/renderer.py 80.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master     #287      +/-   ##
==========================================
- Coverage   95.17%   95.14%   -0.03%     
==========================================
  Files          64       64              
  Lines        3437     3443       +6     
==========================================
+ Hits         3271     3276       +5     
- Misses        166      167       +1     
Flag Coverage Δ
pytests 95.14% <91.66%> (-0.03%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant