Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix submit command usage #1065

Merged
merged 7 commits into from
May 7, 2024

Conversation

andrerfcsantos
Copy link
Member

Fixes #1063

@andrerfcsantos andrerfcsantos force-pushed the fix-submit-usage branch 7 times, most recently from 0335b84 to 642de98 Compare October 12, 2022 23:20
@andrerfcsantos
Copy link
Member Author

Ready to review.

Just a side note about formatting: CI initially was complaining the code was not formatted with go fmt. I found this weird, because my editor runs go fmt to format the code. Turns out the problem seems to be that go1.15 fmt ./... and go1.19 fmt ./... don't agree on the formatting. I had to run go1.15 fmt ./... for CI to be happy. This meant Use: " having just 1 space between the : and ". On the other hand, go1.19 fmt ./... puts more spaces, in an attempt to align all the values of the struct vertically. I like the go1.19 formatting more, but used the go1.15 formatting for CI to pass.

Copy link
Member

@kotp kotp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Non-blocking suggestion for wording.

cmd/submit.go Outdated Show resolved Hide resolved
cmd/submit.go Outdated Show resolved Hide resolved
cmd/submit.go Outdated Show resolved Hide resolved
@kotp
Copy link
Member

kotp commented May 3, 2024

Should that merge have been a rebase on main instead of a merge of main into this branch?

cmd/submit.go Outdated Show resolved Hide resolved
@ErikSchierboom ErikSchierboom merged commit 0d2cbbd into exercism:main May 7, 2024
7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

help text for submit
3 participants