-
-
Notifications
You must be signed in to change notification settings - Fork 362
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Setup goreleaser to update homebrew #1121
Merged
ErikSchierboom
merged 5 commits into
exercism:main
from
baduker:setup-goreleaser-to-update-homebrew
Nov 23, 2023
Merged
Changes from all commits
Commits
Show all changes
5 commits
Select commit
Hold shift + click to select a range
09fd1be
initial brew tap set-up
baduker 7eb80eb
add a missing newline
baduker e41f3e7
update commit_author values
baduker 83a63ba
use repository as tap is deprecated
baduker 7b906a9
remove brew todo and add goreleaser brew tap info
baduker File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -120,5 +120,17 @@ release: | |
# Default is `{{.Tag}}` | ||
name_template: "{{.ProjectName}}-v{{.Version}} {{.Env.USER}}" | ||
|
||
# brews: | ||
# We do not use the brew config, which is for taps, not core forumulas. | ||
brews: | ||
- | ||
name: exercism | ||
repository: | ||
owner: exercism | ||
name: homebrew-exercism | ||
commit_author: | ||
name: Exercism Bot | ||
email: [email protected] | ||
folder: Formula | ||
homepage: "https://exercism.org/" | ||
description: "Command-line tool to interact with exercism.io" | ||
test: | | ||
system "exercism version" |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
is there any way we can test this?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
As far as I'm concerned, I am not aware of a way to explicitly test
brews
section locally. However, I use thisgoreleaser release --snapshot --clean --verbose
Running this command with the proposed changes should give you verbose output, including a section on
homebrew tap formula
. Speaking of which, it's calledrepository
now asbrews.tap
is deprecated. To reproduce rungoreleaser check
and read https://goreleaser.com/deprecations#brewstapNote: I need to comment out this section:
As I don't have access to
Env.GPG_FINGERPRINT
and without thisgpg
complains andgoreleaser
fails locally.Running the above command with the proposed changes in this PR, gives me the following (redacted for brevity):
This indicates that the brews section is being processed correctly and the actual versioned release should generate and publish a homebrew-tap recipe into a repository.