Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

sync connect #865

Open
wants to merge 2 commits into
base: main
Choose a base branch
from
Open

sync connect #865

wants to merge 2 commits into from

Conversation

tomasnorre
Copy link
Contributor

Resolves #851

@github-actions GitHub Actions
Copy link

This PR touches files which potentially affect the outcome of the tests of an exercise. This will cause all students' solutions to affected exercises to be re-tested.

If this PR does not affect the result of the test (or, for example, adds an edge case that is not worth rerunning all tests for), please add the following to the merge-commit message which will stops student's tests from re-running. Please copy-paste to avoid typos.

[no important files changed]

For more information, refer to the documentation. If you are unsure whether to add the message or not, please ping @exercism/maintainers-admin in a comment. Thank you!

@tomasnorre tomasnorre added x:action/sync Sync content with its latest version x:knowledge/elementary Little Exercism knowledge required x:module/practice-exercise Work on Practice Exercises x:type/content Work on content (e.g. exercises, concepts) x:size/small Small amount of work x:rep/small Small amount of reputation labels Nov 17, 2024
@tomasnorre tomasnorre marked this pull request as ready for review November 17, 2024 14:39
@tomasnorre tomasnorre requested a review from mk-mxp November 19, 2024 11:26
@mk-mxp
Copy link
Contributor

mk-mxp commented Dec 8, 2024

See #851 for things to decide before going on.

tomasnorre
tomasnorre commented Dec 21, 2024
View reviewed changes
exercises/practice/connect/.meta/example.php

// Prints the board, occasionally useful for debugging.
// Capital letters indicate a connect flag has been set.
public function dump(): void
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I allowed myself to remove this, as it's not needed for the solution.

@tomasnorre
Copy link
Contributor Author

I hope I understood the feedback correctly.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mk-mxp mk-mxp Awaiting requested review from mk-mxp

At least 1 approving review is required to merge this pull request.

Assignees

@tomasnorre tomasnorre

Labels
x:action/sync Sync content with its latest version x:knowledge/elementary Little Exercism knowledge required x:module/practice-exercise Work on Practice Exercises x:rep/small Small amount of reputation x:size/small Small amount of work x:type/content Work on content (e.g. exercises, concepts)
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Sync connect
2 participants
@tomasnorre @mk-mxp