[config] Fix Android scandir error when ejecting on windows (#2774)

expo · Oct 9, 2020 · 6973eb6 · 6973eb6
1 parent 385603f
commit 6973eb6
Showing 1 changed file with 4 additions and 2 deletions.
diff --git a/packages/config/src/android/Package.ts b/packages/config/src/android/Package.ts
@@ -25,14 +25,16 @@ function getMainApplicationPath({
     cwd: packageRoot,
   });
   // If there's more than one, we'll probably have a problem.
-  return mainApplications[0];
+  // Also, glob always returns a posix formatted path (even on windows),
+  // lets normalize that so we can use it with `.split(path.sep)`
+  return path.normalize(mainApplications[0]);
 }
 
 function getCurrentPackageName(projectRoot: string) {
   const packageRoot = getPackageRoot(projectRoot);
   const mainApplicationPath = getMainApplicationPath({ projectRoot, packageRoot });
   const packagePath = path.dirname(mainApplicationPath);
-  const packagePathParts = packagePath.replace(packageRoot, '').split(path.sep).filter(Boolean);
+  const packagePathParts = path.relative(packageRoot, packagePath).split(path.sep).filter(Boolean);
 
   return packagePathParts.join('.');
 }