perf: skip unnecessary parsing of entire header

expressjs · Sep 27, 2017 · 4c58835 · 4c58835
1 parent 5a7d6a1
commit 4c58835
Show file tree

Hide file tree

Showing 2 changed files with 15 additions and 2 deletions.
diff --git a/HISTORY.md b/HISTORY.md
@@ -7,6 +7,7 @@ unreleased
     - perf: unroll the "fast-path" `RegExp`
   * deps: vary@~1.1.2
     - perf: improve header token parsing speed
+  * perf: skip unnecessary parsing of entire header
 
 2.3.9 / 2017-05-19
 ==================

diff --git a/index.js b/index.js
@@ -110,14 +110,26 @@ function createQueryGetter (key) {
  */
 
 function createHeaderGetter (str) {
-  var header = str.toLowerCase()
+  var name = str.toLowerCase()
 
   return function (req, res) {
     // set appropriate Vary header
     vary(res, str)
 
+    // get header
+    var header = req.headers[name]
+
+    if (!header) {
+      return undefined
+    }
+
     // multiple headers get joined with comma by node.js core
-    return (req.headers[header] || '').split(/ *, */)
+    var index = header.indexOf(',')
+
+    // return first value
+    return index !== -1
+      ? header.substr(0, index).trim()
+      : header.trim()
   }
 }