Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CVPN-1681 Fix failed Kyber/ML-KEM handshake with non-AVX2 CPU #187

Merged
merged 1 commit into from
Dec 23, 2024

Conversation

kp-thomas-yau
Copy link
Contributor

@kp-thomas-yau kp-thomas-yau commented Dec 20, 2024

Description

The patch is from:
wolfSSL/wolfssl#8306

This patch fixes an issue where older CPUs, with no AVX2 support, fail to handshake Kyber/ML-KEM.

Motivation and Context

How Has This Been Tested?

Tested a new server with this fix built in. Old and new clients can indeed connect to it.

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • All active GitHub checks are passing
  • The correct base branch is being used, if not main

The patch is from:
wolfSSL/wolfssl#8306

This patch fixes an issue where older CPUs, with no AVX2 support, fail to handshake Kyber/ML-KEM.
@kp-thomas-yau kp-thomas-yau marked this pull request as ready for review December 20, 2024 08:48
@kp-thomas-yau kp-thomas-yau requested a review from a team as a code owner December 20, 2024 08:48
@kp-thomas-yau kp-thomas-yau merged commit cf9ba8a into main Dec 23, 2024
20 checks passed
@kp-thomas-yau kp-thomas-yau deleted the CVPN-1681-kyber-non-avx2 branch December 23, 2024 02:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants