Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CVPN-1681 Fix failed Kyber/ML-KEM handshake with non-AVX2 CPU #211

Merged
merged 1 commit into from
Dec 27, 2024

Conversation

kp-thomas-yau
Copy link
Contributor

The patch is from:
wolfSSL/wolfssl#8306

This patch fixes an issue where older CPUs, with no AVX2 support, fail to handshake Kyber/ML-KEM.

@kp-thomas-yau kp-thomas-yau marked this pull request as ready for review December 24, 2024 07:33
@kp-thomas-yau kp-thomas-yau requested a review from a team as a code owner December 24, 2024 07:33
Copy link

github-actions bot commented Dec 24, 2024

Code coverage summary for 76c182e:

Filename                             Regions    Missed Regions     Cover   Functions  Missed Functions  Executed       Lines      Missed Lines     Cover    Branches   Missed Branches     Cover
------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------
wolfssl-sys/src/lib.rs                     6                 0   100.00%           3                 0   100.00%          24                 0   100.00%           0                 0         -
wolfssl/src/chacha20_poly1305.rs          14                 2    85.71%           5                 0   100.00%          95                 2    97.89%           0                 0         -
wolfssl/src/context.rs                   172                83    51.74%          45                14    68.89%         344               131    61.92%           0                 0         -
wolfssl/src/error.rs                      19                 7    63.16%           5                 1    80.00%          51                 9    82.35%           0                 0         -
wolfssl/src/lib.rs                        68                14    79.41%          14                 2    85.71%          84                15    82.14%           0                 0         -
wolfssl/src/rng.rs                        19                 5    73.68%           4                 0   100.00%          47                 3    93.62%           0                 0         -
wolfssl/src/ssl.rs                       471               202    57.11%          80                24    70.00%        1065               281    73.62%           0                 0         -
------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------
TOTAL                                    769               313    59.30%         156                41    73.72%        1710               441    74.21%           0                 0         -

✅ Region coverage 59% passes
✅ Line coverage 74% passes

The patch is from:
wolfSSL/wolfssl#8306

This patch fixes an issue where older CPUs, with no AVX2 support, fail to handshake Kyber/ML-KEM.
@kp-thomas-yau kp-thomas-yau force-pushed the CVPN-1681-add-non-avx2-kyber-fix branch from 9e20391 to 243b412 Compare December 24, 2024 07:40
@kp-thomas-yau kp-thomas-yau merged commit 46d4f3a into main Dec 27, 2024
8 checks passed
@kp-thomas-yau kp-thomas-yau deleted the CVPN-1681-add-non-avx2-kyber-fix branch December 27, 2024 03:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants