Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

IBX-5827: Replaced deprecated string interpolation (PHP 8.2+) #386

Merged
merged 6 commits into from
Dec 7, 2023
Merged

IBX-5827: Replaced deprecated string interpolation (PHP 8.2+) #386

merged 6 commits into from
Dec 7, 2023

Conversation

Nattfarinn
Copy link
Contributor

@Nattfarinn Nattfarinn commented Oct 3, 2023 •
edited
Loading

JIRA: https://issues.ibexa.co/browse/IBX-5827

Usage:

Add this to your main composer.json after you install the project (ibexa/core must exists):

    "runtime": {
      "error_handler": "\\Ibexa\\Contracts\\Core\\MVC\\Symfony\\ErrorHandler\\Php82HideDeprecationsErrorHandler"
    }

Requires composer dump-autoload after that.

@sonarqubecloud
Copy link

sonarqubecloud bot commented Oct 3, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@Steveb-p Steveb-p requested a review from a team October 3, 2023 08:18
@konradoboza konradoboza requested a review from a team October 3, 2023 08:19
alongosz
alongosz approved these changes Oct 3, 2023
View reviewed changes
Copy link
Member

@alongosz alongosz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I liked previous interpolation better 🤪 Meh PHP 😀 😅

@Nattfarinn Nattfarinn force-pushed the ibx-5827-string-interpolation branch from b65e02d to 2090bf9 Compare November 29, 2023 09:24
Steveb-p
Steveb-p reviewed Nov 29, 2023
View reviewed changes
composer.json Outdated Show resolved Hide resolved
@sonarqubecloud SonarQubeCloud
Copy link

sonarqubecloud bot commented Nov 30, 2023 •
edited
Loading

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

This was referenced Dec 6, 2023
Closed
Merged
@Nattfarinn Nattfarinn merged commit acd0712 into 1.3 Dec 7, 2023
26 checks passed
@Nattfarinn Nattfarinn deleted the ibx-5827-string-interpolation branch December 7, 2023 12:24
@adriendupuis adriendupuis added the Doc needed The changes require some documentation label May 23, 2024
This was referenced May 23, 2024
Merged
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@alongosz alongosz alongosz approved these changes

@Steveb-p Steveb-p Steveb-p approved these changes

@konradoboza konradoboza konradoboza approved these changes

@kisztof kisztof Awaiting requested review from kisztof

Assignees

@kisztof kisztof

@mikadamczyk mikadamczyk

@alongosz alongosz

Labels
Doc needed The changes require some documentation
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
7 participants
@Nattfarinn @kisztof @Steveb-p @alongosz @konradoboza @mikadamczyk @adriendupuis