[Composer] Added RepositoryTestCase to explicit classmap #387
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Kudos, SonarCloud Quality Gate passed!
|
9 tasks
Steveb-p
approved these changes
Oct 4, 2023
ViniTou
approved these changes
Oct 4, 2023
konradoboza
approved these changes
Oct 4, 2023
Nattfarinn
approved these changes
Oct 4, 2023
mikadamczyk
approved these changes
Oct 4, 2023
alongosz
added a commit
to ezsystems/ezplatform-solr-search-engine
that referenced
this pull request
Oct 4, 2023
For more details see #247 and ezsystems/ezplatform-kernel#387 Key changes: * [Composer] Added league/flysystem-memory and sorted packages (needed for Kernel-based integration tests) * Installed symfony/proxy-manager-bridge * Disabled process timeout when running integration tests
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
v3.3+When adding
RepositoryTestCaseto forward-compatible Ibexa namespace I forgot that those namespaces need to be available for external packages, like Ibexa Solr Bundle, because CI there executes these tests directly. Placing it in the new structure./testsdirectory made it available to kernel only as it belongs toautoload-devsection.As a quick workaround I added this class to composer
autoload.classmap. For Ibexa 4.x we already have ibexa/test-core package which seems to be more appropriate place. I recommend that we spend some time to refactor Solr Bundle tests so they don't rely on test classes from core. We need more common search test shared base.TODO
Checklist:
$ composer fix-cs).