Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

IBX-522: Introduced Docker image for Solr standalone #214

Draft
wants to merge 3 commits into
base: 3.3
Choose a base branch
from
Draft

IBX-522: Introduced Docker image for Solr standalone #214

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
8a85c3f
IBX-519: Introduced Docker image for Solr standalone
Steveb-p Jun 8, 2021
8fd83fb
IBX-519: Added healthcheck
Steveb-p Jun 9, 2021
83812e3
IBX-519: Removed duplicated Solr config files, extend docker context …
Steveb-p Jun 9, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
16 changes: 16 additions & 0 deletions docker/solr/Dockerfile
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,16 @@
FROM solr:8.6.3

LABEL org.opencontainers.image.source=https://github.com/ezsystems/ezplatform-solr-search-engine

USER root
# Note: requires project dir as docker context
# Build using: `docker build -f docker/solr/Dockerfile .` when in project root directory
COPY lib/Resources/config/solr server/solr/configsets/_default/conf
RUN mv server/solr/configsets/_default/conf/schema.xml server/solr/configsets/_default/conf/managed-schema
RUN sed --in-place '/<updateRequestProcessorChain name="add-unknown-fields-to-the-schema".*/,/<\/updateRequestProcessorChain>/d' server/solr/configsets/_default/conf/solrconfig.xml
RUN sed --in-place 's/${solr.autoSoftCommit.maxTime:-1}/${solr.autoSoftCommit.maxTime:20}/' server/solr/configsets/_default/conf/solrconfig.xml
Comment on lines +10 to +11
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why and what are those?

Copy link
Contributor Author

@Steveb-p Steveb-p Jun 8, 2021 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

They come from:

ezplatform-solr-search-engine/bin/generate-solr-config.sh

Lines 121 to 123 in 90c9eb2

# Adapt autoSoftCommit to have a recommended value, and remove add-unknown-fields-to-the-schema
sed -i.bak '/<updateRequestProcessorChain name="add-unknown-fields-to-the-schema".*/,/<\/updateRequestProcessorChain>/d' $DESTINATION_DIR/solrconfig.xml
sed -i.bak2 's/${solr.autoSoftCommit.maxTime:-1}/${solr.autoSoftCommit.maxTime:20}/' $DESTINATION_DIR/solrconfig.xml

They are the only commands (other than straight up copying configuration files to the service) that are required to mimic the behavior of host-based Solr (created when init_solr.sh is executed).

From what I understand first disables automatic field registration as schema, and the second makes Solr commit more often.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Are they really needed in a test environment i.e. not a long-running instance?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Are they really needed in a test environment i.e. not a long-running instance?

As described by @adamwojs in a personal conversation with me, they are needed because sometimes we test against field being empty in search engine, and this apparently is required for it to work. I didn't dig deeper tbh.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Are they really needed in a test environment i.e. not a long-running instance?

Yes, these config changes are required for test environment.


USER solr

HEALTHCHECK --interval=10s --timeout=5s --retries=10 --start-period=15s CMD solr status
CMD ["solr-precreate", "collection1"]